Remove MediaType from public methods in API module #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikkokar
suggested changes
Aug 7, 2018
| public Builder contentType(MediaType mediaType) { | ||
| return addHeader(CONTENT_TYPE, mediaType); | ||
| public Builder contentType(String contentType) { | ||
| return addHeader(CONTENT_TYPE, contentType); |
There was a problem hiding this comment.
I think we should remove contentType methods for now. Seems bit pointless if all it does is to set the header with an arbitrary string. The consumers can just set the Content-Type header directly.
We can add them in if or when we'll add a Styx MediaType abstraction.
mikkokar
reviewed
Aug 7, 2018
| public Builder contentType(MediaType mediaType) { | ||
| return addHeader(CONTENT_TYPE, mediaType); | ||
| public Builder contentType(String contentType) { | ||
| return addHeader(CONTENT_TYPE, contentType); |
There was a problem hiding this comment.
See my comment to the HttpResponse message.
mikkokar
approved these changes
Aug 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.